EPMDEDP-16620: fix: Add proper 404/401 error handling#62
Merged
Conversation
SergK
force-pushed
the
fix-404-error-masking
branch
2 times, most recently
from
a7c2a6d to
3f956d3
Compare
SergK
changed the title
Extract classifyGitHubError helper to centralize GitHub error mapping. Extract isBitbucketNotFound helper for type-safe 404 detection. Add 404>ErrNotFound and 401>ErrUnauthorized mappings to all providers so errors are properly wrapped as domain sentinels instead of raw API errors. This ensures API handlers can correctly map to HTTP status codes. Add 403 (Forbidden) checks to GitLab methods for token scope errors. Fix Bitbucket GetRepository to use typed error helper instead of fragile string comparison. Remove misleading ErrNotFound mapping from ListUserOrganizations since GET /groups never returns 404 in normal operation. Add comprehensive test coverage for 404/401 scenarios across all providers. Signed-off-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
SergK
force-pushed
the
fix-404-error-masking
branch
from
3f956d3 to
f1c16d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract classifyGitHubError helper to centralize GitHub error mapping. Extract isBitbucketNotFound helper for type-safe 404 detection.
Add 404→ErrNotFound and 401→ErrUnauthorized mappings to all providers so errors are properly wrapped as domain sentinels instead of raw API errors. This ensures API handlers can correctly map to HTTP status codes.
Add 403 (Forbidden) checks to GitLab methods for token scope errors. Fix Bitbucket GetRepository to use typed error helper instead of fragile string comparison.
Remove misleading ErrNotFound mapping from ListUserOrganizations since GET /groups never returns 404 in normal operation.
Add comprehensive test coverage for 404/401 scenarios across all providers.