fix(projects): add page heading to /projects/new route header - #9
Merged
Merged
Conversation
The route passed hideHeader to ProjectForm (suppressing its h1) and rendered only the logo in its own header bar, leaving the page with no heading at all — nothing visible saying what the screen is, and no document heading for screen-reader navigation. Render the h1 in the route header next to the logo, separated by a divider, per the issue's preferred option: the heading shares the existing bar instead of stacking a second one.
This was referenced Aug 6, 2026
MeepCastana
approved these changes
Aug 6, 2026
MeepCastana
left a comment
MeepCastana
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed locally on a combined review branch (all six merged clean, no conflicts). CI green. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
What
/projects/newrendered no<h1>anywhere: the route passeshideHeadertoProjectForm(suppressing the form's own heading) and its header bar only contained the logo.How
The issue's preferred option: render the
<h1>in the route header next to the logo (divider between), so the heading shares the existing bar instead of stacking a second one.hideHeaderstays —ProjectForm's internal header remains suppressed, so there is exactly one header bar.For reference,
/projectsitself has noh1/page title either (only anh2inside the empty state), so there was no existing route-title convention to match — this follows the issue's suggested direction instead.Verification
Measured in headless Chromium against the dev server on
/projects/new:document.querySelectorAll('h1').length→ 1 (was 0).panel-headerbars on the page: 1 — no stacked headerslint✅Note
Sits under the #1 redesign umbrella — the redesign can restyle this header (width alignment, back affordance) on top; this PR only closes the missing-h1 gap.