fix: repair ci — integration mkdtemp dir and stale edit-mode e2e specs#37
Merged
Conversation
Integration: pipeline-roundtrip mkdtemps into <root>/.cache, which exists on dev machines but not on a fresh CI checkout — create it first. E2E: edit-flow/edit-workflow specs still tested the removed Edit-button + ?edit= URL-param entry flow, red on every branch since edit mode became always-on for authenticated users. Rewritten against the current model: - auto-entered edit mode (workspace seeded in localStorage, as after a real login → workspace selection; fresh logins redirect to /workspace) - inline click-to-edit cells instead of always-rendered form inputs - Unsaved badge instead of the old 'N changes' text - save flow mocks the workspace edit-branch API (branches, git/refs) with an api.github.com catch-all so nothing hits the network - dropped tests for removed affordances (Edit dropdown, exit button, full/inline switch, expert-disabled-outside-edit)
…on direct-loaded scheme pages nuxt generate prerenders /scheme; loadDefinitions ran during that SSR pass, its workspaces.json fetch fails at build time, and the resulting definitionsLoaded=true + [] state is serialized into the payload. A client that direct-loads a scheme URL hydrates that state, never retries the fetch, activeWorkspace stays null, and every save fails with 'Failed to create edit branch'. (Entering via /workspace masked it — that page loads definitions client-side in onMounted.) loadDefinitions now skips SSR entirely and retries when a previous attempt yielded nothing (covers older poisoned payloads and transient failures).
Collaborator
Author
|
Pushed a second commit: the CI e2e save-test failure exposed a real bug, not a test problem — the prerendered Fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's
Testworkflow has been red on every branch since ~June 22. Two independent causes, both pre-existing onmain(the docs-only #34 fails identically):integration (22s crash)
pipeline-roundtrip.test.tsdoesmkdtempSync(<root>/.cache/…)—.cacheexists on dev machines but not on a fresh CI checkout →ENOENT. Fixed by creating the dir first. Verified locally on a simulated fresh checkout: 10/10 pass.e2e (12 tests failing)
edit-flow.spec.ts+edit-workflow.spec.tsstill tested the removed Edit button /?edit=param entry flow. Edit mode is now always-on for authenticated users, entry is via workspace selection, and inline editing is click-to-edit. Rewritten against the current model:/workspace)Unsavedbadge assertions instead of the old "N changes" textbranches,git/refs) plus anapi.github.comcatch-all so no test traffic leaves the boxFull local run: 22/22 e2e pass (edit + browse + search), unit suite unaffected.
Unblocks meaningful checks on #34 and #36 — suggest merging this first, then rebasing/re-running those.