Fix timing issues in the metronome#161
Closed
blaendverk wants to merge 2 commits into
Closed
Conversation
Owner
|
Hi, thank you for the contribution. Isn't something missing from the PR? It looks like you only updated the mp3 files to wav. What issue specifically are you fixing? As far as I know the reported timing issues were fixed in #151. Are you still experiencing issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some timing and accent issues in the metronome by replacing the delayed callback, with a manually constructed audio stream.
It also replaces the mp3 sound files with wav files, for easier handling.