refactor: Extract shared base classes to eliminate duplication#50
Merged
Conversation
barneyjackson
commented
May 22, 2026
Contributor
- Add _EntityBase with shared id, created_at, eq, hash for Entity and ImmutableEntity
- Add _RepositoryBase with shared session, create, ID extraction, and pagination methods
- BaseRepository and ImmutableBaseRepository become thin subclasses with only their specific behaviour
- Zero breaking changes: all public class names, signatures, and imports unchanged
…ation - Add _EntityBase with shared id, created_at, __eq__, __hash__ for Entity and ImmutableEntity - Add _RepositoryBase with shared session, create, ID extraction, and pagination methods - BaseRepository and ImmutableBaseRepository become thin subclasses with only their specific behaviour - Zero breaking changes: all public class names, signatures, and imports unchanged
Contributor
137 files skipped due to complete coverage. |
Contributor
🐳 Docker Image BuiltThe Docker image for this PR has been built and pushed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.