Skip to content

fix: no such transaction ID - #2226

Open
thibaudgermain wants to merge 1 commit into
LFDT-Panurus:mainfrom
thibaudgermain:fix-2225-no-such-tx
Open

fix: no such transaction ID#2226
thibaudgermain wants to merge 1 commit into
LFDT-Panurus:mainfrom
thibaudgermain:fix-2225-no-such-tx

Conversation

@thibaudgermain

Copy link
Copy Markdown
Contributor

isNotFoundError function takes 3 possible cases

// - "code = NotFound" — raw gRPC status text
// - "not found in index" — committer's gRPC status desc field
// - "tx not found" — FSC finality.TxNotFound sentinel appended

But miss 'no such transaction ID' error case

It means that the operation is blocked forever, and never marked as orphan

Fixes #2225

Signed-off-by: Thibaud Germain <thibaud.germain1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: recoverTransaction miss 'error no such transaction ID' case

1 participant