fix(evm): catch the evm module up with the tracked modules - #2228
Open
atharrva01 wants to merge 2 commits into
Open
fix(evm): catch the evm module up with the tracked modules#2228atharrva01 wants to merge 2 commits into
atharrva01 wants to merge 2 commits into
Conversation
The v0.17.0 upgrade updated the tracked modules and missed this one, so nothing under x/token/services/network/evm builds until go.mod is tidy. Signed-off-by: atharrva01 <atharvaborade568@gmail.com>
LFDT-Panurus#2180 enabled containedctx and fixed the ttx occurrence. The evm module is a separate Go module and was not linted in that pass, so make lint has been failing on it since. Neither field can be dropped. Ledger.ctx exists because driver.GetStateFnc passes no context to GetState, and fakeContext.ctx exists because it implements view.Context, whose Context() method has to return one. Signed-off-by: atharrva01 <atharvaborade568@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evm driver is its own Go module under
x/, so changes that sweep the tracked modules do not reachit. Two have been missed and the branch has been red on both since:
go.modon v0.16.0, so nothing in the module buildsand
tidy-checkfailscontainedctxand fixed the ttx occurrence, leaving two in the evm module thatmake linttrips onNeither of those two fields can be dropped, so they get a waiver with the reason next to it.
Ledger.ctxexists becausedriver.GetStateFncpasses no context toGetState, andfakeContext.ctxbecause it implementsview.Context, whoseContext()method has to return one.make lintandgo test ./...are both clean on the module afterwards.