Conversation
This was referenced Jun 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 51.71% 51.74% +0.02%
==========================================
Files 42 42
Lines 7315 7251 -64
==========================================
- Hits 3783 3752 -31
+ Misses 3532 3499 -33
Continue to review full report at Codecov.
|
to BoundingBox and OrientedBoundingBox also make the BoundingBox fields public for simplicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #153
Renamed
Aabb(axis aligned bounding box) to justBoundinxBoxAlso renamed
MbrtoOrientedBoundingBox(instead of arbitrarily oriented bounding box). Let me know if you have a better name for this.Aabb is used for rcb in #165 to keep track of the min/max of each coordinate