test(decode): collapse runtime success paths in boundary - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
crates/dsview-sys/tests/boundary.rsinto a single runtime lifecycleinit -> exit -> initcycles in one boundary test binaryWhy
Linux CI showed that
dsview-sysboundary tests could corrupt heap state when decode runtime metadata success-path tests repeatedly initialized and exited the decode runtime in the same process.This change keeps the same contract coverage while matching the runtime usage pattern more closely and avoiding the failing repeated-successful-init path.
Validation
cargo test -p dsview-sys --target x86_64-unknown-linux-gnu --test boundary -- --nocapture --test-threads=1MALLOC_CHECK_=3 PYTHONMALLOC=debug RUST_BACKTRACE=full DSVIEW_DECODE_DEBUG=1 cargo test -p dsview-sys --target x86_64-unknown-linux-gnu --test boundary -- --nocapture --test-threads=1