fix(test): Prevent creation of test_data directory during unit tests#41
Merged
Conversation
WinstonLiyt
reviewed
Jul 26, 2025
WinstonLiyt
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue #39 where running unit tests would create an unexpected
test_datadirectory. This side effect, caused by automatic directory creation in the globalSettingmodel, has been removed to ensure a cleaner developer experience and prevent unintended file system modifications.Key Changes
data_dirandtemp_dirfields, along with their validating directory-creation logic, have been removed from the mainSettingmodel inquantmind/config/settings.py.storagecomponent (e.g.,LocalStorageConfig), which manages its own directory structure.tests/config/test_settings.pyhave been updated to remove checks for the global paths and now perform their own cleanup of storage-related artifacts, ensuring tests are self-contained.Implementation Notes
The
field_validatorthat created directories uponSettinginitialization was the source of the unwanted side effects. By removing it and the associated fields, theSettingclass becomes a pure data container, and components likeLocalStorageproperly encapsulate their own resource management. This enhances modularity and predictability.Checklist
Please feel free to remove inapplicable items for your PR.