fix(ui): SizeDisplay binding must be OneWay (read-only property)#20
Merged
Conversation
LLMSettingsView.xaml bound Run.Text to SizeDisplay with the default TwoWay mode. SizeDisplay is a read-only computed property (getter only), so WPF threw XamlParseException at template instantiation time, crashing the entire LLM provider card list whenever models were present. Adding Mode=OneWay tells WPF to only read source -> target, which is valid for read-only properties.
4 tasks
LXBStudioLLC
added a commit
that referenced
this pull request
Jul 5, 2026
Run.Text defaults to TwoWay in WPF. When bound to a read-only or init-only property, WPF throws XamlParseException at template instantiation, crashing the entire view. PR #20 fixed SizeDisplay in LLMSettingsView. This PR fixes the remaining 7 Run.Text bindings across 4 XAML files: - BrowserSelectionView.xaml: StatusText - DashboardView.xaml: Email, Phone, Experience.Count, Skills.Count - FindJobsView.xaml: Company, Location - LLMSettingsView.xaml: StatusText, ModelCountText Every Run Text={Binding...} in the codebase now has Mode=OneWay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash when opening the LLM Settings view (Ollama options) when models are present.
Root Cause
LLMSettingsView.xamlline 95 bound<Run Text="{Binding SizeDisplay}"/>. TheRun.Textdependency property defaults toTwoWaybinding mode.LLMModelInfo.SizeDisplayis a read-only computed property (getter only, no setter). WPF throwsInvalidOperationException→ wrapped asXamlParseExceptionwhen it tries to activate aTwoWaybinding on a read-only property, crashing the entireDataTemplateinstantiation for every model in the list.Fix
Added
Mode=OneWayto the binding:This tells WPF to only read source → target (one-directional), which is valid for read-only properties.
Test Results
Checklist