Fix 25 verified LOW code-review findings (for v1.0.2)#23
Merged
Conversation
…gic, style) Verified 67 LOW findings; 25 were real and are fixed here, 13 were skipped as unreachable or no-op (unreachable ApplyFilter nulls, test HttpClients wrapping stub handlers, a non-existent temp dir, a misread RepostFrequency count). - Null safety: guard null JobTitle (PostingAgeSignal), null Evidence (GhostScorer), null provider (OllamaService.SwitchProvider). - Culture: ToUpperInvariant/ToLowerInvariant for internal key-code, stop-word, match-score, and template-action/field normalization (Turkish-locale safe). - Resource: dispose the CDP receive-loop MemoryStream. - Logic: DomScorer tie-break keeps the first candidate; SafetyService keyword density uses exact-token match (no more "java" in "javascript"); remove dead host-check branches in AtsCrossCheckSignal. - Tests: derive the ATS source-count assertions from the expected set. - Scripts: BOM-free Start Envoy.bat; release the WScript.Shell COM objects. - Style: drop a redundant Debug.WriteLine; frozen Theme.CardSurface + reuse frozen brushes in VaultView; make SeedBoards.Default a true read-only list. 135/135 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified the 67 LOW findings against current main. 25 were real and are fixed here; 13 were skipped as unreachable or no-op (details in the commit). Build clean, 135/135 tests pass. Headed into the held v1.0.2.
Groups: null-safety guards, culture-invariant casing (Turkish-locale bugs), a MemoryStream leak, logic fixes (DomScorer tie-break, SafetyService exact-token keyword match, dead-code removal), test-robustness, BOM-free .bat + COM release in the installer scripts, and frozen-brush/immutable-collection style fixes.
🤖 Generated with Claude Code