Multi value text choices #7323
Open
Multi value text choices #7323
+630
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2026
labkey-matthewb
requested changes
Jan 14, 2026
| protected void setValue(ObjectProperty property, Object value) | ||
| { | ||
| throw new UnsupportedOperationException("TODO MultiChoice"); | ||
| if ((value instanceof java.sql.Array array)) |
Contributor
There was a problem hiding this comment.
If we expect a limited number possible types for value we could assert here, or else maybe use MultiChoice.Converter.getInstance().convert()
| { | ||
| if (value.toString().trim().isEmpty()) | ||
| { | ||
| values.add(null); |
Contributor
There was a problem hiding this comment.
I suspect we want this to be an zero-length list? e.g. return List.of()?
| _register(new JSONTypeConverter(), JSONObject.class); | ||
| _register(new ShortURLRecordConverter(), ShortURLRecord.class); | ||
| _register(new ColumnHeaderType.Converter(), ColumnHeaderType.class); | ||
| _register(MultiChoice.Converter.getInstance(), MultiChoice.class); |
Contributor
There was a problem hiding this comment.
MultiChoice.Array.class
| { | ||
| elements[i] = jsonArray.get(i); | ||
| } | ||
| return new MultiChoice.Array(Arrays.stream(elements)); |
Contributor
There was a problem hiding this comment.
I'm not sure this is the right approach. I think we want to keep the distinction between PropertyType.MULTI_CHOICE and JdbcType.ARRAY. Otherwise, it might be confusing when connecting to tables that use ARRAY or even filtering on columns created using ARRAY[] SQL syntax which might not be text[].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds support for multi-value text choice properties, enabling users to select multiple values for text choice fields. This functionality is controlled by an experimental feature flag and is only supported on PostgreSQL databases for data types that are backed by provisioned table.
Related Pull Requests
Changes