McpService #7329
Draft
McpService #7329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migration to spring-ai for chat client
test-chat.view (AbstractAgentAction)
register resources with mcpserver
labkey-matthewb
requested review from
labkey-jeckels
and removed request for
labkey-jeckels
| import org.springframework.ai.chat.model.ToolContext; | ||
| import java.util.Map; | ||
|
|
||
| public class McpContext implements ContainerUser |
Contributor
There was a problem hiding this comment.
A sentence or two of docs would be helpful here too.
| // Build URL with same base as current document, endpoint /query-queryagent.api and prompt parameter | ||
| var url = new URL('./query-queryagent.api', window.location.href); | ||
| url.searchParams.set('prompt', prompt); | ||
| var req = new XMLHttpRequest(); |
Contributor
There was a problem hiding this comment.
Worth using LABKEY.Ajax instead?
Contributor
Author
There was a problem hiding this comment.
This code is really trash. I hope it is not long lived.
|
|
||
|
|
||
| @Override | ||
| public ToolCallback @NonNull [] getToolCallbacks() |
Contributor
There was a problem hiding this comment.
Returning arrays always feels clunky. Consider a Collection of some sort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
McpService for registering MCP tools, etc.
Basic chat page for testing (test-chat.view)
Related Pull Requests
Changes