fix: resolve lost-update race condition in top-up endpoint - #1358
Open
composure-lad wants to merge 2 commits into
Open
fix: resolve lost-update race condition in top-up endpoint#1358composure-lad wants to merge 2 commits into
composure-lad wants to merge 2 commits into
Conversation
Closes LabsCrypt#1295 Replaced non-atomic application-level balance updates with an atomic Prisma $queryRaw statement to ensure concurrent top-up requests don't overwrite each other's state changes. Added a concurrent test to verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Functional Edge Case #15 (lost-update race condition in top-ups) and adds the requested concurrent integration test as specified in the audit.
$queryRawhandles concurrent top-ups correctly without lost updatestest tobackend/tests/integration/top-up.test.tsCloses #1295