fix(ci): pin pr-test-gate Postgres version to match ci.yml and docs - #1387
Open
Ajibose wants to merge 1 commit into
Open
fix(ci): pin pr-test-gate Postgres version to match ci.yml and docs#1387Ajibose wants to merge 1 commit into
Ajibose wants to merge 1 commit into
Conversation
Aligns pr-test-gate.yml's Postgres service image with the version already pinned in ci.yml and docker-compose.yml (16-alpine, digest pinned) and updates docs/DEVELOPMENT.md's stated version floor accordingly, so the backend/Prisma test suite runs against the same Postgres major version everywhere instead of drifting between 15, 16, and a documented "14+" floor. Closes LabsCrypt#1282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1282
Summary
The backend/Prisma test suite was running against three different Postgres versions depending on where it executed:
postgres:16-alpine(digest-pinned) inci.yml, plainpostgres:15inpr-test-gate.yml, and a documented floor of "PostgreSQL 14+" indocs/DEVELOPMENT.md. This risked version-specific SQL/Prisma behavior differences going undetected in whichever path wasn't exercised for a given change, and could produce "passes in one CI workflow, fails in the other" flakiness unrelated to the code under test.This PR pins all three sources to Postgres 16, matching the version already used in
docker-compose.yml(the production target) andci.yml.Changes
Modified files
.github/workflows/pr-test-gate.yml— thebackend-testjob's Postgres service image is changed frompostgres:15topostgres:16-alpine@sha256:e013e867e712fec275706a6c51c966f0bb0c93cfa8f51000f85a15f9865a28cb, the same digest-pinned image already used byci.ymlanddocker-compose.yml. A comment notes the three files should stay in sync.docs/DEVELOPMENT.md— the prerequisites list now states "PostgreSQL 16 (matches the version pinned indocker-compose.ymland CI)" instead of "PostgreSQL 14+".New files
None.
Test files
None — this is a CI/documentation-only change. There is no application code path to unit test; the correctness of the change is that all three sources now name the same Postgres major version (16), which is verifiable by inspection and by the
pr-test-gate.ymlworkflow itself running successfully against the pinned image on this PR.Implementation details
postgres:16-alpineimage reference fromci.yml/docker-compose.ymlrather than a barepostgres:16tag, so all three service definitions resolve to the identical image and stay reproducible.postgresservice block inpr-test-gate.yml(env vars, ports, health-check options) untouched — only the image reference changed.How to test
.github/workflows/ci.yml—postgres:16-alpine@sha256:....github/workflows/pr-test-gate.yml—postgres:16-alpine@sha256:...(same digest)docs/DEVELOPMENT.md— "PostgreSQL 16"backend-testjob runs successfully against the Postgres 16 service container.