fix: stop poison-pill batches from freezing indexer cursor - #1422
Open
ponmileleke54-dev wants to merge 3 commits into
Open
fix: stop poison-pill batches from freezing indexer cursor#1422ponmileleke54-dev wants to merge 3 commits into
ponmileleke54-dev wants to merge 3 commits into
Conversation
Collaborator
|
resolve conflict on this issue @ponmileleke54-dev |
1 similar comment
Collaborator
|
resolve conflict on this issue @ponmileleke54-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the poison-pill batch regression where a single malformed event in a batch caused the indexer cursor to freeze and prevented later valid events in the same batch from being processed on the next poll.
Changes
Verification
RUN v3.2.7 /workspaces/flowfi/backend
✓ tests/soroban-event-worker.test.ts (13 tests) 130ms
Test Files 1 passed (1)
Tests 13 passed (13)
Start at 11:35:49
Duration 791ms (transform 215ms, setup 0ms, collect 449ms, tests 130ms, environment 0ms, prepare 67ms)
This keeps later valid events from being reprocessed forever while still preserving the no-retry behavior for the failed event itself.
closed #1292