Skip to content

Save Windows vcpkg cache before tests#4

Merged
adsharma merged 1 commit into
mainfrom
codex/save-vcpkg-cache-before-tests
May 24, 2026
Merged

Save Windows vcpkg cache before tests#4
adsharma merged 1 commit into
mainfrom
codex/save-vcpkg-cache-before-tests

Conversation

@adsharma

Copy link
Copy Markdown
Contributor

Summary

  • split the Windows vcpkg cache step into explicit restore and save actions
  • save the populated vcpkg binary cache immediately after the Windows dependency install succeeds
  • keep build and test failures from discarding the expensive vcpkg binary cache upload

Root cause

The combined actions/cache step only saves during post-job cleanup after a successful job. If Windows tests fail after vcpkg spends ~40 minutes building Arrow, the new C:\vcpkg-binary-cache contents are not uploaded, so the next main run is cold again.

Validation

  • git diff --check
  • parsed .github/workflows/build-and-deploy.yml with Ruby YAML.load_file

@adsharma adsharma changed the title [codex] Save Windows vcpkg cache before tests Save Windows vcpkg cache before tests May 24, 2026
@adsharma adsharma marked this pull request as ready for review May 24, 2026 20:05
@adsharma adsharma merged commit e09ead9 into main May 24, 2026
4 checks passed
@adsharma adsharma deleted the codex/save-vcpkg-cache-before-tests branch May 24, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant