feat: implement provably extract LIMIT/OFFSET circuits (Part1)#288
Open
Insun35 wants to merge 10 commits into
Open
feat: implement provably extract LIMIT/OFFSET circuits (Part1)#288Insun35 wants to merge 10 commits into
Insun35 wants to merge 10 commits into
Conversation
Insun35
force-pushed
the
feat/provably-extract-limit-offset
branch
3 times, most recently
from
f34c61f to
cc9b20a
Compare
Insun35
changed the title
Insun35
changed the title
Insun35
changed the title
Insun35
force-pushed
the
feat/provably-extract-limit-offset
branch
2 times, most recently
from
9384db3 to
4377c28
Compare
Insun35
force-pushed
the
feat/provably-extract-limit-offset
branch
from
4377c28 to
27f8fb3
Compare
Insun35
force-pushed
the
feat/provably-extract-limit-offset
branch
from
27f8fb3 to
1ab5337
Compare
Insun35
changed the title
nicholas-mainardi
suggested changes
Aug 12, 2024
- replace accumulator input from final_tree_hash to tree_hash - add test for accumulator check
Add new method to properly initialize the circuit ensuring that indexed_items[1] == U256::ZERO if it is a dummy value. Also modify test code to use new method when constructing the circuit.
4 tasks
nicholas-mainardi
approved these changes
Aug 14, 2024
nicholas-mainardi
left a comment
nicholas-mainardi
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just a minor comment
| .chain(empty_hash_fields) | ||
| .chain(indexed_items[1].to_fields()) | ||
| .chain(indexed_items[1].to_fields()) | ||
| .chain(second_indexed_item.unwrap_or(U256::ZERO).to_fields()) |
Contributor
There was a problem hiding this comment.
Minor: we could replace this with test_circuit.second_indexed_item so that we don't have to do this unwrap_or everywhere?
delehef
force-pushed
the
main
branch
8 times, most recently
from
d8cf76a to
a9e2b59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issue #181
Intermediate and No-results circuits will be implemented on follow up PR because the size of this PR may be too large.
Refer to the results extraction circuits spec.