Receipts working with Generic Struct Extraction#430
Open
Zyouell wants to merge 318 commits into
Open
Conversation
…n column gadget.
…et_unsafe` for initializing with one target.
…d into the metadata digest.
nicholas-mainardi
left a comment
nicholas-mainardi
left a comment
Contributor
There was a problem hiding this comment.
Took a look at the circuit code again to see changes done. Nice improvements but I think there are still a couple of changes to be done to circuits and APIs
nicholas-mainardi
left a comment
nicholas-mainardi
left a comment
Contributor
There was a problem hiding this comment.
Looks definitely better now, thanks for all the changes! I think that in terms of circuits the only thing left is binding the extraction ids of extracted columns to the data found in the receipt trie node, and the potential issue with the RLP decoding of the transaction index. Other previous issues look solved now to me. All other comments are all minor/quick things. I will take a look to all the non circuit code as well next.
| } | ||
| } | ||
|
|
||
| pub struct BlockUtil { |
Contributor
There was a problem hiding this comment.
Why not moving it to test module given that it seems to be used only in tests?
Base automatically changed from
generic-extraction-integration-test-mapping-of-mappings
to
generic-extraction-integration-test
March 5, 2025 11:16
Base automatically changed from
generic-extraction-integration-test
to
generic-extraction-row-id-update
March 5, 2025 14:24
Base automatically changed from
generic-extraction-row-id-update
to
generic-extraction-tree-creation
March 5, 2025 14:51
Base automatically changed from
generic-extraction-tree-creation
to
generic-mpt-extraction
March 5, 2025 15:41
Base automatically changed from
generic-mpt-extraction
to
feat/new_extraction_features
March 5, 2025 21:04
nicholas-mainardi
force-pushed
the
feat/new_extraction_features
branch
from
9d292a7 to
0d3f1d4
Compare
delehef
force-pushed
the
feat/new_extraction_features
branch
2 times, most recently
from
1345edd to
9a0932c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes CRY-21 upon merge.
A very sizeable PR that makes the Generic Struct Extraction Code and Receipt Extraction Code work together.
It has made reasonably large differences to both. The most noticeable is the change to
ColumnData,ColumnDataGadgetandMetadataGadget. Since the EVM only works in bytes I have removed thebit_offsetaspects of the code and rewritten the extraction circuits to reflect this. They now no longer use lookups which should result in an overall speed up in proving time (since you no longer have to run the lookup PIOP).In addition to this, instead of just having
ColumnInfowe now haveExtractedColumnInfoandInputColumnInfo. This is to reduce work done when computing value digests but still keep everything grouped together.The Receipt extraction now uses the new
TableMetadatastruct just like struct extraction does and I have also made aFrom<EventLogInfo>implementation to easily construct columns with identifiers.I tried to remove some of the unnecessary generic constants (for instance those on storage leaf nodes and MPT extension nodes) that have a fixed length when viewed in a circuit. In order to make the compiler stop complaining about
unconstrained generic constantI had to use the actual number values rather than being able to declare a constant and use that.For Receipt proving in the integration test we use the code in
mp2_v1/src/value_extraction/planner.rssince we don't need to keep track of previous value extraction in the receipt case.