chore: fix broken dev tooling and dead CI/doc references - #987
Merged
Conversation
Conservative dev-tooling/doc hygiene (this is the live C# backend):
- .vscode/launch.json: drop the FunderMaps.WsClient debug config (project
no longer exists in src/), and fix the Webservice + WebApi program paths
from net8.0 → net10.0 (all csproj target net10.0, so F5 debug was
pointing at a non-existent DLL).
- .github/workflows/dotnet-core.yml: remove the two commented-out test
jobs targeting FunderMaps.IntegrationTests.{Portal,Webservice} — neither
project exists. The active FunderMaps.Webservice.Tests job is untouched.
- README.md: `contrib/etc/` is a directory of files, not a single
`_appsettings.{ENV}.json` "directory" — reworded.
Deliberately left untouched (need your call):
- scripts/deploy.sh publishes src/FunderMaps.Worker/, which moved to the
FunderMapsWorker repo — the correct publish target for this script is a
deployment decision, not a mechanical fix.
- .github/workflows/codeql-analysis.yml has every analysis step commented
out (only checkout runs) — re-enable vs delete is a CI-policy call.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conservative dev-tooling/doc hygiene — no production runtime code touched (this is the live C# backend; default branch
develop).Fixed
.vscode/launch.json— removed theFunderMaps.WsClientdebug config (the project no longer exists undersrc/), and fixed theWebservice+WebApiprogram paths fromnet8.0→net10.0. All.csprojtargetnet10.0, so F5 debug was pointing at a non-existent DLL..github/workflows/dotnet-core.yml— removed the two commented-out test jobs targetingFunderMaps.IntegrationTests.{Portal,Webservice}; neither project exists. The activeFunderMaps.Webservice.Testsjob is untouched.README.md—contrib/etc/is a directory containing_appsettings.{ENV}.jsonfiles, not a "directory" named after the file pattern. Reworded.Deliberately left untouched (need your call)
scripts/deploy.sh— line 35 doespushd src/FunderMaps.Worker/, which moved to the FunderMapsWorker repo. The script is broken as-is, but the correct publish target (Webservice? Docker? something else) is a deployment decision, not a mechanical fix — flagging rather than guessing on a prod deploy script..github/workflows/codeql-analysis.yml— every analysis step (init/autobuild/analyze) is commented out; onlycheckoutruns, so it produces a misleading green check. Re-enable vs delete is a CI-policy call.🤖 Generated with Claude Code