fix(invoer): drop the "adressen missen een funderingstype" check - #293
Merged
Conversation
A sample records what a report observed, and plenty of reports observe an address without ever establishing its foundation type. Treating that as an incomplete dossier was wrong on the facts, and it showed up twice: - Controle (step 3): an amber callout claiming the address "werkt niet door in de kaart en de producten", plus the same sentence repeated in the submit confirm dialog. Both gone; `isClean` no longer requires a foundation type, so these dossiers now get the green "klaar om aan te bieden" callout they always deserved. - Dossier view: a `blocker` telling people the dossier could not go to review until the field was filled. Gone; it now falls through to the generic pipeline sentence. The "N met funderingstype" stat on the dossier view stays — that is a count, not a complaint. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sample records what a report observed, and plenty of reports observe an address without ever establishing its foundation type. Treating a missing
foundationTypeas an incomplete dossier was wrong on the facts, and it showed up in two places.Controle (step 3) —
InquiryStep3.vuewithoutFoundationTypecomputed behind it.isCleanno longer requires a foundation type, so a dossier of otherwise-complete samples now gets the green "Klaar om aan te bieden" callout instead of a false warning. Its wording lost the "hebben een funderingstype" clause.Dossier view —
InquiryView.vueblockerline "N van de N adressen mist een funderingstype. Zodra dat gevuld is kan het dossier ter controle." — removed. It now falls through to the generic pipeline sentence. The blocker still names the two real facts: no addresses at all, and addresses that are completely empty.The "· N met funderingstype" stat stays — that is a count, not a complaint, so
completeness.withFoundationTypeis still computed.pnpm type-checkclean. No behaviour change beyond the removed warnings; nothing gated submission before, so nothing is newly unblocked.🤖 Generated with Claude Code