Resolve the data-layer anchor against the running style - #278
Merged
Conversation
The hardcoded 'building-number-label-hover' beforeId only existed in the legacy Mapbox style; after the basemap swap every addLayer threw and no data layers rendered. Resolve the anchor at runtime instead: env override, then the purple boundary lines, then the first symbol layer, then on top - a missing id degrades placement, never the mapset. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #273/#277: data layers were inserted
before: 'building-number-label-hover'— a layer id that only existed in the legacy Mapbox Studio style. After the basemap swap everyaddLayerthrew ("Cannot add layer … before non-existing layer") and no data layers rendered. The anchor now resolves at runtime:VITE_FUNDERMAPS_NUMBER_LAYERif set and present, else the purple boundary lines, else the first symbol layer, else top-of-stack.Data layers land below boundaries and labels — text stays readable over extrusions.
🤖 Generated with Claude Code