feat(map): serve facade_scan and incident layers from the tileserver - #290
Merged
Conversation
Adds the five remaining static sources to dynamicSources so they are added via their TileJSON endpoint on tiles.fundermaps.com instead of the raw Spaces bucket. Backed by the new maplayer function sources in FunderMapsWorker (create_facade_scan_tiles.sql, create_incident_tiles.sql). No layer config changes: the MVT layer names match the old tileset names, and every config already uses source == source-layer == tileset name. This is now every source the configs reference, so the static branch is only reachable as a rollback. Keeping it (and the sourceZoomLevels overrides it needs) means a rollback is one name off the list rather than a logic redeploy; it can be removed once the cutover has held. Note: the incident sources now carry municipality_id/district_id/ neighborhood_id, so the existing geofence starts applying to them. On 'Schiedam publiek' (public, fenced to GM0606) that takes the incident layer from all 2,728 Dutch incidents down to Schiedam's 216. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the five remaining static sources to
dynamicSourcesso they are added via their TileJSON endpoint on tiles.fundermaps.com instead of the raw Spaces bucket.Backed by Laixer/FunderMapsWorker#73 (
create_facade_scan_tiles.sql,create_incident_tiles.sql), which movesfacade_scanand the four incident tilesets off the nightly tippecanoe build — ~40 of the ~50 minutesprocess_mapsetspends every night, for 8,774 features.No layer config changes
The MVT layer names match the retired tileset names, and every config already uses
source == source-layer == tileset name. All ten affected configs (facade-*,skewed-*,incident*) are untouched.Rollback
This is now every source the configs reference, so the static branch below is only reachable as a rollback. It — and the
sourceZoomLevelsoverrides it needs — are deliberately kept, so rolling back is one name off the list rather than a logic redeploy. Both can go once the cutover has held.Behaviour change
The incident sources now carry
municipality_id/district_id/neighborhood_id, which the static tiles never had. The geofence inuseGeographyFilter.tsbuildsany(match(<id>, fence), !has(<id>)), so features missing the id were always shown.On
Schiedam publiek— public, fenced toGM0606via the client-side override instore/mapsets.ts, and it includes the incident layer — that takes the layer from all 2,728 Dutch incidents down to Schiedam's 216. See the Worker PR for the full write-up.Verification
vue-tsc --noEmitandeslintboth clean.🤖 Generated with Claude Code