Skip to content

Fix 403 error when fetching spa data (wrong spa ID resolved from profile) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fsoderblom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 403 error when fetching spa data (wrong spa ID resolved from profile) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions spa_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,23 @@ def get_profile(self):
"User-Agent": "Mozilla/5.0"
}

# Fetch user profile to extract spa ID
# Fetch user profile (mainly to validate the token)
response = self.session.get(PROFILE_URL, headers=headers)
response.raise_for_status()

# Extract spa ID from user profile
profile_data = response.json().get("data", {})
user_data = profile_data.get("user", {})
self.spa_id = user_data.get("_id")


# Fetch the actual spa ID from the spa list. The profile's user "_id"
# is the account ID, not the spa ID, and using it causes a 403 when
# fetching spa data.
spa_response = self.session.get("https://iot.controlmyspa.com/spas", headers=headers)
spa_response.raise_for_status()

spas = spa_response.json().get("data", {}).get("spas", [])
if not spas:
raise ValueError("No spas found in account")

self.spa_id = spas[0].get("_id")
if not self.spa_id:
raise ValueError("Spa ID could not be extracted from profile response")
raise ValueError("Spa ID could not be extracted from spa list response")


def fetch_spa_data(self):
Expand Down