Skip to content

feat: additive workflows: + review_templates: manifest blocks#66

Merged
LanNguyenSi merged 1 commit intomasterfrom
feat/workflows-block
May 6, 2026
Merged

feat: additive workflows: + review_templates: manifest blocks#66
LanNguyenSi merged 1 commit intomasterfrom
feat/workflows-block

Conversation

@LanNguyenSi
Copy link
Copy Markdown
Owner

Summary

  • Adds two optional top-level fields to the manifest under version: 1: workflows: (array of named workflows with branch / review_subagent / ci_gate / merge steps) and review_templates: (map of template name to checklist body).
  • Schema rejects: duplicate workflow names, unknown step kind, spawn: required without a template, and template: references not defined in review_templates.
  • Surfaces via harness describe --pillar workflows | review_templates, harness list workflows, and a new Workflows section in harness doctor (rendered only when something is declared).
  • No runtime enforcement yet, that ships as a follow-up. Manifests without workflows: parse identically to before.

Why

Codifies guidance that lives today as prose in memory files (feedback_always_review, feedback_review_briefing, feedback_one_branch_per_task) into a machine-readable, validator-checked surface. Adopters and remote agents now have a single declarative place to consult instead of three feedback memos.

Refs agent-tasks 7b81734d.

Scope cut

  • Schema + parser + validator + describe / list / doctor probe only.
  • No runtime spawning of review subagents.
  • No apply rendering changes.
  • No schema v2 bump.

Test plan

  • npm run typecheck clean
  • npx vitest run 686 / 686 green (added 8 cli/workflows + 9 schema cases + 4 invalid fixtures)
  • Dogfood: describe --pillar workflows, list workflows, validate against good + each invalid fixture, doctor Workflows banner all behave as expected
  • Reviewed by subagent against rigorous checklist, no blockers

Add two new optional top-level fields under version: 1, declaring
review-subagent gating, branch policy, CI gate, and merge method as
data instead of prose in memory files. Schema rejects duplicate
workflow names, unknown step kinds, spawn: required without a
template, and template references not defined in review_templates.
Surfaces via describe --pillar workflows / review_templates,
list workflows, and a Workflows section in doctor. No runtime
enforcement; that ships separately. Manifests without workflows:
parse identically.

Refs agent-tasks 7b81734d.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@LanNguyenSi LanNguyenSi merged commit 806fb54 into master May 6, 2026
1 check passed
@LanNguyenSi LanNguyenSi mentioned this pull request May 6, 2026
10 tasks
LanNguyenSi added a commit that referenced this pull request May 6, 2026
Bump package.json 0.6.0 -> 0.7.0. Roll up CHANGELOG [Unreleased]
into [0.7.0] - 2026-05-06 with a one-paragraph headline plus
operator note. PR refs (#65, #66, #67, #68, #69) added to each
entry. README now references v0.7.0 in the prose and gains a
status checklist row for the workflows-as-data + session-export +
docs-split set. Two version-pinned tests bumped to match the new
binary header.

Theme: workflows-as-data and full-session audit forensics. No
schema bump (still version: 1); all new manifest fields are
additive and parse identically against 0.6.0 manifests.

Refs agent-tasks 1fe55885.

Co-authored-by: Lan Nguyen Si <nguyen-si@publicplan.de>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants