Refactor backend game logic into Models and Managers#10
Refactor backend game logic into Models and Managers#10google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Introduced `RoomManager` singleton for managing room lifecycles. - Introduced `Room` class to encapsulate room state (users, messages, settings) and socket communication. - Introduced `Game` class to encapsulate core game logic (timer, turns, word validation) and extend EventEmitter. - Refactored `gameHandler.ts` to use the new `RoomManager` and `Room` classes. - Added `src/utils/logger.ts` for centralized logging configuration. - Added unit tests for `Game` model in `tests/game.test.ts`. - Removed global `rooms` map and monolithic logic in `gameHandler.ts`. - Updated dependencies to include `pino-pretty`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This PR refactors the backend architecture to be more modular, testable, and efficient. It moves away from the monolithic "God Function" in
gameHandler.tsand global mutable state maps. Instead, it adopts a domain-driven approach withRoomandGamemodels and aRoomManager. This structure improves code readability, separates concerns (socket logic vs. game logic), and allows for unit testing of the game rules independent of the socket server. The frontend data contract is preserved via DTO generation inRoom.toDTO().PR created automatically by Jules for task 9146467851549917274 started by @Laosing