Enhance the faq section#182
Conversation
|
@Dipanita45 is attempting to deploy a commit to the larythelord's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @Dipanita45 — great work on #183 (How It Works just merged)! For this one (#182), you've expanded the Privacy Policy, but the issue asks for FAQ section enhancements. Two options:
Which would you prefer? Either way, you'll get the 75 XP + 2 skill points once approved! |
LarytheLord
left a comment
There was a problem hiding this comment.
Hey @Dipanita45 — the FAQ page work is solid! The category grouping and accordion toggle are exactly what was asked for in issue #171. Well done.
The privacy/terms expansions look like genuine improvements too (more comprehensive content, better formatting).
Before this merges, two things:
- The
metadataexport and'use client'directive can't coexist on the same page — you have both onapp/faq/page.tsx. Movemetadatato a separatelayout.tsxin theapp/faq/folder, or remove it from the client component. - The privacy/terms changes are much bigger than the FAQ scope. It would be cleaner as two PRs, but if you want to keep it in one, just make sure the content is accurate — especially the new sections about public profile visibility and data sharing.
Fix point 1 and this is ready to go!
LarytheLord
left a comment
There was a problem hiding this comment.
Hey @Dipanita45 — the FAQ page work is solid! The category grouping and accordion toggle are exactly what was asked for in issue #171. Well done.
The privacy/terms expansions look like genuine improvements too (more comprehensive content, better formatting).
Before this merges, two things:
- The
metadataexport and'use client'directive can't coexist on the same page — you have both onapp/faq/page.tsx. Movemetadatato a separatelayout.tsxin theapp/faq/folder, or remove it from the client component. - The privacy/terms changes are bigger than the original FAQ scope — they look good but make sure the content is accurate, especially the new sections on public profile visibility and data sharing.
Fix point 1 and this is ready to go!
|
Done |
|
I can also keep in another pr for privacy |
|
Check and thank you for the guide |
|
Hey @Dipanita45 — the main apostrophe issue is now fixed on main. Please rebase your branch on main to pick up the fix: Once rebased CI should pass! |
|
Done |
|
Hey @Dipanita45! Quick heads-up from the NSoC 2026 program guidelines — contributors are limited to 3 open issues at a time to keep the review queue manageable. Right now you have:
That's already at the limit! Please focus on getting PR #192 resolved first (it needs the merge conflict fixed with Steps to fix PR #192: git fetch origin
git checkout <your-branch>
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-leaseOnce both PRs are merged, you'll be clear to pick up new issues. Thanks for your contributions — just keeping things flowing! 🙏 |
|
Merged this pr
…On Tue, 28 Apr 2026, 6:04 pm Abi, ***@***.***> wrote:
*LarytheLord* left a comment (LarytheLord/Adventurers-Guild#182)
<#182 (comment)>
Hey @Dipanita45 <https://github.com/Dipanita45>! Quick heads-up from the
NSoC 2026 program guidelines — contributors are limited to *3 open issues
at a time* to keep the review queue manageable.
Right now you have:
- PR #182 <#182>
(this one — FAQ enhancement)
- PR #192 <#192>
(privacy page improvements — currently has a merge conflict)
- Issue #171
<#171>
(assigned)
That's already at the limit! Please focus on getting *PR #192
<#192>* resolved
first (it needs the merge conflict fixed with git rebase origin/main),
and hold off on picking up new issues until these are merged.
Steps to fix PR #192
<#192>:
git fetch origin
git checkout <your-branch>
git rebase origin/main# resolve any conflicts, then:
git push --force-with-lease
Once both PRs are merged, you'll be clear to pick up new issues. Thanks
for your contributions — just keeping things flowing! 🙏
—
Reply to this email directly, view it on GitHub
<#182 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7SRZ6E27G3CP2EUYVKSPGL4YCQM7AVCNFSM6AAAAACX7AVAN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMZVGI2TMNBYHE>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @Dipanita45 — thanks for this PR. Two blockers before we can merge: 1. CI is failing on a JSX parse error Open 2. Same parse error in your other PR's Once both are fixed and CI is green, this is good to merge. The accordion FAQ structure with Let me know if you want help locating the exact line. |
|
Done please merge |
|
@Dipanita45 — Reviewed again after your update. The chatbot is still in this PR. Looking at the diff, import Chatbot from "@/components/Chatbot";
// ...
<Chatbot />And This PR is currently two things bundled together:
To unblock this PR today, do exactly these three steps: # 1. Remove the chatbot component file
git rm components/Chatbot.tsx
# 2. Remove the chatbot import and usage from layout.tsx
# Open app/layout.tsx and delete:
# import Chatbot from "@/components/Chatbot";
# <Chatbot />
# 3. Push the change
git pushAlso update this FAQ answer in
Replace with:
Once those two things are done, this merges same day. The FAQ work is solid. |
|
Done |
|
Hi @Dipanita45! 👋 I reviewed your latest work — the FAQ accordion looks great! But there are just 3 small things blocking merge, and then this is ready: 1. Remove the chatbot from this PR ✂️ Steps: git rm components/Chatbot.tsx
# Then edit app/layout.tsx and delete:
# import Chatbot from "@/components/Chatbot";
# <Chatbot />
git add -A && git commit -m "Remove chatbot (separate PR #210)"
git push2. Update one FAQ answer ✏️
Update to:
3. Push to re-trigger CI 🚀 That's it! Once these are done, this merges same day. The FAQ work is solid. Any blockers? Reply here and I can help you through it. You've got this! 💪 |
Code Review — PR #182: FAQ EnhancementOverall: ✅ Good to merge (small change)This is a focused, incremental improvement. The accordion pattern is cleaner than the previous Q&A list. What's great:
Minor notes:
Verdict: ✅ Approve |

Quest Reference
Changes
Issue No: #171
Acceptance Criteria Checklist
Screenshots (if UI changes)
Peer Review Checklist (for reviewer)