Skip to content

Enhance the faq section#182

Open
Dipanita45 wants to merge 9 commits into
LarytheLord:mainfrom
Dipanita45:main
Open

Enhance the faq section#182
Dipanita45 wants to merge 9 commits into
LarytheLord:mainfrom
Dipanita45:main

Conversation

@Dipanita45
Copy link
Copy Markdown
Contributor

Quest Reference

  • Quest ID/Link:
  • Track: OPEN / INTERN / BOOTCAMP
  • Rank: F / E / D / C / B+
  • Source: BACKLOG / HACKATHON / CLIENT_PORTAL / INTERNAL / TUTORIAL

Changes

Issue No: #171

Acceptance Criteria Checklist

  • Criteria 1
  • Criteria 2

Screenshots (if UI changes)

Peer Review Checklist (for reviewer)

  • Code does what the quest brief asks
  • All acceptance criteria met
  • Follows existing code patterns
  • No obvious bugs or edge cases
  • Comfortable sending to client

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 20, 2026

@Dipanita45 is attempting to deploy a commit to the larythelord's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Dipanita45
Copy link
Copy Markdown
Contributor Author

image

@LarytheLord
Copy link
Copy Markdown
Owner

Hey @Dipanita45 — great work on #183 (How It Works just merged)!

For this one (#182), you've expanded the Privacy Policy, but the issue asks for FAQ section enhancements.

Two options:

  1. Update this PR to target app/home/page.tsx → find the FAQ section and expand those questions/answers with more detail (e.g., add questions about quest matching, payouts, ranks, etc.)
  2. Close this and start fresh with a new PR focused on the FAQ

Which would you prefer? Either way, you'll get the 75 XP + 2 skill points once approved!

Copy link
Copy Markdown
Owner

@LarytheLord LarytheLord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dipanita45 — the FAQ page work is solid! The category grouping and accordion toggle are exactly what was asked for in issue #171. Well done.

The privacy/terms expansions look like genuine improvements too (more comprehensive content, better formatting).

Before this merges, two things:

  1. The metadata export and 'use client' directive can't coexist on the same page — you have both on app/faq/page.tsx. Move metadata to a separate layout.tsx in the app/faq/ folder, or remove it from the client component.
  2. The privacy/terms changes are much bigger than the FAQ scope. It would be cleaner as two PRs, but if you want to keep it in one, just make sure the content is accurate — especially the new sections about public profile visibility and data sharing.

Fix point 1 and this is ready to go!

Copy link
Copy Markdown
Owner

@LarytheLord LarytheLord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dipanita45 — the FAQ page work is solid! The category grouping and accordion toggle are exactly what was asked for in issue #171. Well done.

The privacy/terms expansions look like genuine improvements too (more comprehensive content, better formatting).

Before this merges, two things:

  1. The metadata export and 'use client' directive can't coexist on the same page — you have both on app/faq/page.tsx. Move metadata to a separate layout.tsx in the app/faq/ folder, or remove it from the client component.
  2. The privacy/terms changes are bigger than the original FAQ scope — they look good but make sure the content is accurate, especially the new sections on public profile visibility and data sharing.

Fix point 1 and this is ready to go!

@Dipanita45
Copy link
Copy Markdown
Contributor Author

Done

@Dipanita45
Copy link
Copy Markdown
Contributor Author

I can also keep in another pr for privacy

@Dipanita45
Copy link
Copy Markdown
Contributor Author

Check and thank you for the guide

@LarytheLord
Copy link
Copy Markdown
Owner

Hey @Dipanita45 — the main apostrophe issue is now fixed on main. Please rebase your branch on main to pick up the fix:

git fetch origin
git rebase origin/main
git push --force-with-lease

Once rebased CI should pass!

@Dipanita45
Copy link
Copy Markdown
Contributor Author

Done

@LarytheLord
Copy link
Copy Markdown
Owner

Hey @Dipanita45! Quick heads-up from the NSoC 2026 program guidelines — contributors are limited to 3 open issues at a time to keep the review queue manageable.

Right now you have:

That's already at the limit! Please focus on getting PR #192 resolved first (it needs the merge conflict fixed with git rebase origin/main), and hold off on picking up new issues until these are merged.

Steps to fix PR #192:

git fetch origin
git checkout <your-branch>
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Once both PRs are merged, you'll be clear to pick up new issues. Thanks for your contributions — just keeping things flowing! 🙏

@LarytheLord LarytheLord mentioned this pull request Apr 28, 2026
7 tasks
@Dipanita45
Copy link
Copy Markdown
Contributor Author

Dipanita45 commented Apr 28, 2026 via email

@LarytheLord
Copy link
Copy Markdown
Owner

Hi @Dipanita45 — thanks for this PR. Two blockers before we can merge:

1. CI is failing on a JSX parse error

app/faq/page.tsx:94 - Parsing error: Expected corresponding JSX closing tag for <p>

Open app/faq/page.tsx around line 94 — there's an unclosed <p> tag. Fix by either closing the tag or removing the stray opener.

2. Same parse error in your other PR's app/privacy/page.tsx:95
I closed PR #192 as a duplicate of this one. If you want the privacy page changes too, fold them into this branch — but fix the same <p> issue at line 95 of app/privacy/page.tsx.

Once both are fixed and CI is green, this is good to merge. The accordion FAQ structure with useState + ChevronDown looks solid and the 'use client' directive is correct.

Let me know if you want help locating the exact line.

@Dipanita45
Copy link
Copy Markdown
Contributor Author

Done please merge

@Dipanita45 Dipanita45 requested a review from Adil2009700 as a code owner May 1, 2026 18:47
@LarytheLord
Copy link
Copy Markdown
Owner

@Dipanita45 — Reviewed again after your update. The chatbot is still in this PR.

Looking at the diff, app/layout.tsx still adds:

import Chatbot from "@/components/Chatbot";
// ...
<Chatbot />

And components/Chatbot.tsx is still included in this PR's files.

This PR is currently two things bundled together:

  1. ✅ FAQ accordion redesign — ready to merge
  2. ❌ Chatbot — placeholder that always replies "Got it! We will help you soon 🚀" regardless of input

To unblock this PR today, do exactly these three steps:

# 1. Remove the chatbot component file
git rm components/Chatbot.tsx

# 2. Remove the chatbot import and usage from layout.tsx
# Open app/layout.tsx and delete:
#   import Chatbot from "@/components/Chatbot";
#   <Chatbot />

# 3. Push the change
git push

Also update this FAQ answer in app/faq/page.tsx:

"Currently, Adventurers Guild tracks rewards but does not process payments."

Replace with:

"Adventurers receive 85% of the quest reward via Razorpay bank transfer. The platform takes a 15% fee."

Once those two things are done, this merges same day. The FAQ work is solid.

@LarytheLord LarytheLord mentioned this pull request May 2, 2026
7 tasks
@Dipanita45
Copy link
Copy Markdown
Contributor Author

Done

@LarytheLord
Copy link
Copy Markdown
Owner

Hi @Dipanita45! 👋

I reviewed your latest work — the FAQ accordion looks great! But there are just 3 small things blocking merge, and then this is ready:

1. Remove the chatbot from this PR ✂️
The chatbot is a separate feature (issue #181). This PR should be FAQ-only.

Steps:

git rm components/Chatbot.tsx
# Then edit app/layout.tsx and delete:
#   import Chatbot from "@/components/Chatbot";
#   <Chatbot /> 
git add -A && git commit -m "Remove chatbot (separate PR #210)"
git push

2. Update one FAQ answer ✏️
In components/landing/FAQSection.tsx (or wherever the FAQ text is), find this answer:

"Currently, Adventurers Guild tracks rewards but does not process payments."

Update to:

"Adventurers receive 85% of their quest reward via bank transfer. The platform takes a 15% commission to support operations."

3. Push to re-trigger CI 🚀

That's it! Once these are done, this merges same day. The FAQ work is solid.

Any blockers? Reply here and I can help you through it. You've got this! 💪

@LarytheLord
Copy link
Copy Markdown
Owner

Code Review — PR #182: FAQ Enhancement

Overall: ✅ Good to merge (small change)

This is a focused, incremental improvement. The accordion pattern is cleaner than the previous Q&A list.

What's great:

  • Accordion with ChevronDown animation is smooth and clean
  • Category grouping (General, Companies, Payments, Submissions) makes navigation easier
  • Dark theme is consistent with the rest of the site
  • Click-to-expand is much better UX than a long scroll

Minor notes:

  • The "Payments & Ownership" answer says "Adventurers receive 85% via Razorpay bank transfer, 15% platform fee" — this may need verification against the actual payment model. If this isn't the current implementation, it could mislead users. Check with @LarytheLord if this is accurate.
  • Both PR Enhance the faq section #182 and Add the chatbot #210 touch app/faq/page.tsx. They'll conflict — whichever merges first wins, then the other needs a rebase.

Verdict: ✅ Approve
Clean, focused improvement. Merge before #210 to avoid conflicts on app/faq/page.tsx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants