Skip to content

Allow use of the native Android Debug Bridge#53

Open
DanTheMan827 wants to merge 18 commits into
Lauriethefish:mainfrom
DanTheMan827:adb-websocket
Open

Allow use of the native Android Debug Bridge#53
DanTheMan827 wants to merge 18 commits into
Lauriethefish:mainfrom
DanTheMan827:adb-websocket

Conversation

@DanTheMan827
Copy link
Copy Markdown
Contributor

@DanTheMan827 DanTheMan827 commented Mar 16, 2025 •
edited
Loading

This allows the website to connect to the local adb server through a websocket proxy

https://github.com/dantheman827/mbf-bridge/

@DanTheMan827 DanTheMan827 force-pushed the adb-websocket branch 13 times, most recently from 7d55d8f to 81de910 Compare March 24, 2025 22:02
@Lauriethefish
Copy link
Copy Markdown
Owner

Lauriethefish commented Mar 25, 2025

Is there a reason this PR includes making the agent support any app ID? I'd probably prefer this to be in a different PR, esp. given that the implementation of it here isn't ideal. (i.e. would prefer not to use a command line arg for the agent and would also prefer not having a bunch of different oncelocks for each static path)

@DanTheMan827 DanTheMan827 force-pushed the adb-websocket branch 4 times, most recently from f33d8a4 to 0d9e605 Compare March 29, 2025 19:35
@DanTheMan827 DanTheMan827 marked this pull request as ready for review March 29, 2025 19:37
@DanTheMan827
Copy link
Copy Markdown
Contributor Author

DanTheMan827 commented Mar 29, 2025 •
edited
Loading

I removed the commit to change the game id of the agent from this branch, but I would like to add it at some point as a dev option at least (I have two BS installs as an example)

@DanTheMan827 DanTheMan827 force-pushed the adb-websocket branch 2 times, most recently from 43b079c to 400d02c Compare March 29, 2025 22:50
@DanTheMan827 DanTheMan827 changed the title Allow use of an adb bridge Allow use of the native Android Debug Bridge Mar 29, 2025
@DanTheMan827 DanTheMan827 mentioned this pull request Apr 3, 2025
Merged
Lauriethefish
Lauriethefish reviewed Apr 14, 2025
View reviewed changes
Comment thread mbf-site/src/AdbServerWebSocketConnector.ts Outdated
Comment thread mbf-site/src/AdbServerWebSocketConnector.ts
Comment thread mbf-site/src/Agent.ts Outdated
Comment thread mbf-site/src/App.tsx
Lauriethefish
Lauriethefish reviewed Apr 14, 2025
View reviewed changes
Comment thread mbf-site/package.json Outdated
@DanTheMan827 DanTheMan827 force-pushed the adb-websocket branch 2 times, most recently from 02c2b40 to 706bc87 Compare April 15, 2025 18:14
@Lauriethefish Lauriethefish mentioned this pull request May 4, 2025
Open
@DanTheMan827 DanTheMan827 force-pushed the adb-websocket branch 3 times, most recently from 9d0abda to 45e24da Compare July 24, 2025 15:19
@Lauriethefish
Copy link
Copy Markdown
Owner

Lauriethefish commented Aug 1, 2025

Conflicts need resolving again

@DanTheMan827 DanTheMan827 force-pushed the adb-websocket branch 4 times, most recently from c2384c4 to ae4df3c Compare September 3, 2025 22:19
@DanTheMan827
Copy link
Copy Markdown
Contributor Author

DanTheMan827 commented Sep 3, 2025

I’ve merged the head, and it doesn’t fail to build… but I don’t know if it functions.

@DanTheMan827
Allow use of the native Android Debug Bridge
f201be6 
This allows the website to connect to the local adb server through a websocket proxy
@DanTheMan827
Don't scan for devices if a device was chosen
1213f02
@DanTheMan827
Update credits
7de920d
@DanTheMan827
Use specified bridge, and ping every 5 seconds once a device is conne…
86cf8dd 
…cted
@DanTheMan827
Improve device connection handling
08b31aa
@DanTheMan827
Add OpenLogsButton to device selection and improve CSS layout for con…
74d06ce 
…nected devices
@DanTheMan827
Skip oculus check if bridge detected
02040ba
@DanTheMan827
Refactor logging to include raw data in console log messages for impr…
c73a9eb 
…oved debugging
@DanTheMan827
Implement disconnect tracking for old adb server versions
0dc63e3
@DanTheMan827
Refactor sendRequest to work with the chunks as they are sent from th…
cd5a664 
…e pipe
@DanTheMan827
Re-factor bridge data into a class
8cd9e63
@DanTheMan827
Auto-connect if bridge and only one device is found
9e0b7ea
@DanTheMan827
Update disconnect detection logic
ab80467
@DanTheMan827
chore: update dependencies and improve error handling
2c0ccd7 
- Moved "@yume-chan/stream-extra" from devDependencies to dependencies
- Enhanced WebSocket error handling with logging
- Log errors during stream close in WebSocketConnection
- Removed unneccesary AGENT_SHA1 empty check
@DanTheMan827
Refactor code to split App component
e9280e4
@DanTheMan827
Refactor device and connection management
c2493f0 
- Removed DeviceStore and SyncStore, consolidating their functionality into a new context-based approach.
- Introduce DeviceConnector and BridgeManager hooks to manage device connections and bridge interactions.
- Updated ModManager, OptionsMenu, and other components to utilize the new context for device management.
- Refactor operation modals to use a new context-based approach.
- Add a missing key in the ChooseDevice component.
@DanTheMan827
Abstract bridge interface to allow for different bridges
0e8861b
@DanTheMan827
Implement __mbfBridge ADB connector
2432f7b 
This uses a custom `__mbfBridge` window object injected by a wrapper app to connect to the native adb server running on the device.
@DanTheMan827
Copy link
Copy Markdown
Contributor Author

DanTheMan827 commented Apr 11, 2026

@Lauriethefish I’ve abstracted the ADB connector logic, and also added support for a global __mbfBridge object that can be implemented by apps (and potentially even browser extensions) to allow for connection to the ADB server on the host machine without needing to create a web socket.

I’ve kept the web socket connector in this branch, but it could just as well be removed. The factory method allows for multiple potential connectors (or just one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lauriethefish Lauriethefish Lauriethefish left review comments

+1 more reviewer

@MrWoods024 MrWoods024 MrWoods024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanTheMan827 @Lauriethefish @MrWoods024