feat: profit and loss - quarter and year scopes #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszantas
commented
Nov 29, 2024
| import { CategoricalChartFunc } from 'recharts/types/chart/generateCategoricalChart' | ||
| import { Props as LegendProps } from 'recharts/types/component/DefaultLegendContent' | ||
|
|
||
| const getChartWindow = ({ |
Contributor
Author
There was a problem hiding this comment.
FYI: I moved most of such functions into ./utils.ts to thin this file
tomaszantas
commented
Nov 29, 2024
| .map(x => summarizePnL(x)) | ||
| }, [selectionMonth, chartWindow, data, loaded, compactView]) | ||
| /** @TODO temp */ | ||
| const len = period === 'year' ? 1 : period === 'quarter' ? 4 : 12 |
Contributor
Author
There was a problem hiding this comment.
FYI: Temporary - just to limit number of bars on the chart. It needs to be removed when API endpoint is ready
tomaszantas
commented
Nov 29, 2024
| @@ -0,0 +1,171 @@ | |||
| import React, { ReactNode, useState } from 'react' | |||
Contributor
Author
There was a problem hiding this comment.
Not sure if this file is needed at all. The difference between "v1" and "v2" are not large but noticeable.
To discuss: how much we can modify layouts (views) provided with the package in terms of client awareness for such changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add quarter and year scopes to the PnL chart.
To-do:
How this has been tested?
Screen.Recording.2024-11-29.at.19.06.57.mov