Merged
Conversation
torkelrogstad
commented
Dec 4, 2025
Comment on lines
-31
to
-48
| # Define a common function to configure shared settings for targets | ||
| def configure_target() | ||
| config = use_native_modules! | ||
| target 'BlueWallet' do | ||
| use_native_modules! | ||
|
|
||
| use_react_native!( | ||
| # Specify the path directly if use_native_modules! does not provide it | ||
| :path => config[:reactNativePath], | ||
| :path => "../node_modules/react-native", | ||
| :app_path => "#{Pod::Config.instance.installation_root}/.." | ||
|
|
||
| ) | ||
|
|
||
| pod 'react-native-bw-file-access', :path => '../blue_modules/react-native-bw-file-access' | ||
| end | ||
|
|
||
|
|
||
| target 'BlueWallet' do | ||
| configure_target() | ||
| end | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Look into if we can avoid this
torkelrogstad
force-pushed
the
2025-12-03-redwallet
branch
from
44d9b9d to
b7dbf16
Compare
torkelrogstad
force-pushed
the
2025-12-03-redwallet
branch
2 times, most recently
from
e6272b7 to
695dd5f
Compare
torkelrogstad
force-pushed
the
2025-12-03-redwallet
branch
2 times, most recently
from
be780d7 to
1388dc3
Compare
torkelrogstad
force-pushed
the
2025-12-03-redwallet
branch
4 times, most recently
from
0343300 to
6a772bc
Compare
Networks can be selected through tapping the beast image within the About screen 20 times. The network is stored in the app settings, as well as in a global var in the code base. The alternative to a global var was to do big refactors in order to encapsulate more Electrum operations into a class/object which could be given a network field. An approach with a new wallet class was also considered. However, there's a large quantity of calls to `bitcoin.address.fromOutputScript`, block explorer URL construction and other places where the selected network is required. This commit tries to strike a decent balance between diff size and cleanliness.
1. Update name 2. Update icons 3. Remove LN interface elements 4. Update default electrum server 5. Update default block explorer 6. Update Telegram group 7. Give credits to the BlueWallet developers
torkelrogstad
force-pushed
the
2025-12-03-redwallet
branch
from
6a772bc to
c313db0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI:
TODO:
Looks like not being able to reach node.forknet.drivechain.info:50001 is a source of test failures...bad connection: {"host":"node.forknet.drivechain.info","tcp":50001} Error: connect ECONNREFUSED 157.180.8.224:50001