Skip to content

fix: multichain pt2 audit fixes#528

Merged
ypatil12 merged 3 commits into
devfrom
release-dev/multichain-pt2-audit-fixes
Aug 11, 2025
Merged

fix: multichain pt2 audit fixes#528
ypatil12 merged 3 commits into
devfrom
release-dev/multichain-pt2-audit-fixes

Conversation

@ypatil12

@ypatil12 ypatil12 commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

ypatil12 and others added 2 commits August 8, 2025 12:05
**Motivation:**

Natspec review updates

**Modifications:**

- Add error reason to natspec
- Add event messages

**Result:**

Cleaner code

---------

Co-authored-by: eigenmikem <michael.muehl@eigenlabs.org>
**Motivation:**

As part of an audit finding, to protect against [second preimage
attacks](https://flawed.net.nz/2018/02/21/attacking-merkle-trees-with-a-second-preimage-attack/),
we add a salt to the leaf similar to the RewardsCoordinator to
significantly reduce the likelihood of an internal node being used to
produce an unintentional proof.
Layr-Labs/eigenlayer-contracts#1580 in core
already did this on the cert verifier side. We now need to do this for
table calc

**Modifications:**

- Inherit `LeafCalculatorMixin` in `BN254TableCalculatorBase`
- Use `calculateOperatorInfoLeaf`

**Result:**

Secure code
@ypatil12 ypatil12 force-pushed the release-dev/multichain-pt2-audit-fixes branch from b8458dd to aff4dbc Compare August 8, 2025 16:05
nadir-akhtar
nadir-akhtar previously approved these changes Aug 11, 2025
@ypatil12 ypatil12 merged commit a43dc4b into dev Aug 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants