fix(tool): require plain-object parameter roots per OpenAI tools contract - #262
Merged
Conversation
fix(provider): object-root union schemas for all openai-compatible backends
…ract
Root-level anyOf in tool parameters violated the OpenAI tools contract:
OpenAI tolerated it, DeepSeek rejected it with a schema error, and GLM
silently emitted empty tool arguments (live-reproduced: five consecutive
workflow calls decoded as got {}). Replace the transport-level patch
with a structural contract:
- workflow Parameters: nest the 10-branch discriminated union under a
single params property; the wire root is now a plain object
- Tool.define: assert at construction time that parameters serialize to
a plain object root; violations fail registration with guidance
- provider transform: drop the openai-compatible root-anyOf patch,
superseded by the source-level contract
- native runtime gate: key off the SDK transport package instead of the
providerID so OpenAI-compatible relays can use the native path
LeXwDeX
force-pushed
the
fix/tool-params-object-root
branch
from
August 14, 2026 09:55
7bff31f to
2c89feb
Compare
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structural replacement for the transport-level root-anyOf patch (#260, superseded):
paramsproperty — the provider-facing schema root is now a plain object on every transport. Call shape:{ params: { action, ...fields } }.type: object, no root combinator). Violations fail tool registration with guidance instead of degrading at provider runtime.type: objectpatch is deleted — superseded by the source-level contract.api.npm) instead of providerID, so OpenAI-compatible relays (local proxies, DeepSeek, GLM gateways) can use the native path.Why (live-reproduced evidence)
Root-level combinators are outside the OpenAI tools contract:
arguments: '{}'; params-wrapped schema →arguments: {"params":{"action":"list"}}The v1.0.11
type: objectpatch was necessary (DeepSeek) but insufficient (GLM needs no root combinator at all). This PR removes the need for any transport-level translation.Test plan
workflow-schema-contract.test.ts: plain-object root across 4 transports, 10 branches intact inparams, decode shape, root shortcut rejectedtool-define.test.ts: root-combinator tool dies at construction with actionable messagebun x tsgo --noEmitclean;bun test test/tool test/dag814 pass / 0 fail