Create new first-person-fingerspelling model#62
Merged
Conversation
✅ Deploy Preview for soft-babka-dec3e0 canceled.
|
Owner
Author
|
Small code issue - patching. |
Collaborator
|
model is def more accurate, but note that it is almost impossible to distinguish between letters that are extremely similar that are not visible from the camera, such as n vs m |
Owner
Author
That is an issue either way... its a mediapipe thing... however if you have your thumb pushed enough such that its visilbe when you put m or n it should work better. Either way nothing much we can do about this unless with the current limitations of the physical product - because if we need to keep it ergonomic then yeah... @Sreshty-Beshty LGTM plz? |
Collaborator
|
yup lg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Sreshty-Beshty PTAL and test maybe?