Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for the bls12377g1 and jubjub curves to the manifest/parameter encoding layer, enabling these curves to be represented in derivation path curve bitmasks.
Changes:
- Added new curve flag constants and exposed them through the
CurveFlagsEnum. - Extended manifest derivation path serialization to recognize
bls12377g1andjubjubcurve strings. - Documented the addition in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ledgerwallet/params.py |
Introduces new curve bit flags and adds them to the Curve flags enum. |
ledgerwallet/manifest.py |
Adds string-to-flag mapping for bls12377g1 and jubjub during derivation path serialization. |
CHANGELOG.md |
Notes the new curve support in a new 0.10.0 entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.