Skip to content

Fix stack consumption fixture when test does not interact with device#274

Merged
mbrousset-ledger merged 3 commits into
masterfrom
mbr/fix-stack-fixture
Apr 29, 2026
Merged

Fix stack consumption fixture when test does not interact with device#274
mbrousset-ledger merged 3 commits into
masterfrom
mbr/fix-stack-fixture

Conversation

@mbrousset-ledger
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@bigspider bigspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some nits

Comment thread CHANGELOG.md Outdated
Comment thread src/ragger/conftest/base_conftest.py
Comment thread src/ragger/conftest/base_conftest.py Outdated
@mbrousset-ledger mbrousset-ledger force-pushed the mbr/fix-stack-fixture branch 2 times, most recently from c923875 to 6c86754 Compare April 29, 2026 09:04
@LedgerHQ LedgerHQ deleted a comment from github-actions Bot Apr 29, 2026
@LedgerHQ LedgerHQ deleted a comment from github-actions Bot Apr 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.98%. Comparing base (5eafad3) to head (cd66935).

Files with missing lines Patch % Lines
src/ragger/conftest/base_conftest.py 15.78% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files          38       38           
  Lines        2286     2286           
=======================================
  Hits         1737     1737           
  Misses        549      549           
Flag Coverage Δ
apex_p-py3.10 75.89% <15.78%> (ø)
apex_p-py3.11 75.89% <15.78%> (ø)
apex_p-py3.12 75.89% <15.78%> (ø)
apex_p-py3.13 75.89% <15.78%> (ø)
flex-py3.10 75.89% <15.78%> (ø)
flex-py3.11 75.89% <15.78%> (ø)
flex-py3.12 75.89% <15.78%> (ø)
flex-py3.13 75.89% <15.78%> (ø)
nanos-py3.10 74.32% <15.78%> (ø)
nanos-py3.11 74.32% <15.78%> (ø)
nanos-py3.12 74.32% <15.78%> (ø)
nanos-py3.13 74.32% <15.78%> (ø)
nanosp-py3.10 74.36% <15.78%> (ø)
nanosp-py3.11 74.36% <15.78%> (ø)
nanosp-py3.12 74.36% <15.78%> (ø)
nanosp-py3.13 74.36% <15.78%> (ø)
nanox-py3.10 74.32% <15.78%> (ø)
nanox-py3.11 74.32% <15.78%> (ø)
nanox-py3.12 74.32% <15.78%> (ø)
nanox-py3.13 74.32% <15.78%> (ø)
stax-py3.10 75.89% <15.78%> (ø)
stax-py3.11 75.89% <15.78%> (ø)
stax-py3.12 75.89% <15.78%> (ø)
stax-py3.13 75.89% <15.78%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbrousset-ledger mbrousset-ledger merged commit 3b5ca0d into master Apr 29, 2026
59 checks passed
@mbrousset-ledger mbrousset-ledger deleted the mbr/fix-stack-fixture branch April 29, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants