get_stack_consumption fixture update#275
Open
mbrousset-ledger wants to merge 1 commit intomasterfrom
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "Stack consumption not supported: app not built with DEBUG_OS_STACK_CONSUMPTION=1" | ||
| if e.status == StatusWords.SWO_INVALID_CLA else f"Unexpected SW: {e.status:04X}") | ||
| pytest.fail(msg) | ||
| except Exception: |
Contributor
There was a problem hiding this comment.
I actually agree with Claude here.
Either we can add an explanatory comment here or maybe in a more thin way to catch exactly the connection error and ignore it as potentially possible, but to raise exception on others:
except ConnectionError: # To be check if this is the exact error when Speculos has died
pass
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 75.98% 75.88% -0.10%
==========================================
Files 38 38
Lines 2286 2289 +3
==========================================
Hits 1737 1737
- Misses 549 552 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbrousset-ledger
force-pushed
the
mbr/stack-apdu-no-failure
branch
from
3a08f1c to
1cee628
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using get_stack_consumption fixture, only fail if retcode is
0x6e00(SWO_INVALID_CLA).This will prevent failures due to the test intentionally quitting speculos, at which point stack usage retrieval is not possible.