fix(sec-auto): aikido Fix 13 security issues in undici, @fastify/busboy - #4
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
fix(sec-auto): aikido Fix 13 security issues in undici, @fastify/busboy#4aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI AutoFix
These PRs will require human vetting and potentially some fixes to fully integrate with the codebase.
Upgrade undici and @fastify/busboy to fix HTTP request smuggling, decompression DoS, and WebSocket crashes.
✅ Code not affected by breaking changes.
✅ No breaking changes from the undici upgrade affect this codebase directly.
The codebase does not directly use undici - it's only a transitive dependency through
@actions/githuband@actions/http-client. The source code does not use any of the removed features (throwOnError,interceptors, ordeduplicateinterceptor).The action runs on Node.js 24 (specified in
action.yml), which satisfies undici 7.x's requirement of Node.js >= 18.The upgrade path depends on whether
@actions/githuband@actions/http-clienthave released versions compatible with undici 7.x. Since this codebase doesn't directly control or use undici's API, the risk is low as long as the intermediate dependencies are updated appropriately.All breaking changes by upgrading undici from version 5.29.0 to 6.27.0 (CHANGELOG)
✅ 13 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
undicilibrary are vulnerable to memory leaks. By making multiple fetch requests with the sameAbortSignal, undici adds event listeners without removing them, leading to excessive memory consumption.__proto__orconstructor, potentially influencing application behavior or enabling further attacks.__proto__,constructor, orprototypeinto internal objects, potentially modifying the prototype chain and influencing application behavior or enabling further attacks.🤖 Remediation details
Fix critical and high-severity vulnerabilities in
undiciand@fastify/busboyvia parent dependency bumpsShort summary
This PR remediates multiple vulnerabilities in two transitive packages —
undiciand@fastify/busboy— by bumping their upstream parent dependencies in the rootpackage.json. Theyarn.locklockfile is updated accordingly; noresolutionsoverrides remain in the final state.undici
undiciwas installed transitively at5.29.0through the chain@actions/core/@actions/github→@actions/http-client→undici. The^5.xranges declared by the old parents could never resolve to the patched6.xline, so parent bumps were required.@actions/corewas raised from^1.10.0to^2.0.0and@actions/githubfrom^6.0.0to^8.0.0; those releases pull@actions/http-client@^3.0.2, which in turn declaresundici@^6.23.0, allowing Yarn to resolveundicito6.27.0— the minimum version that satisfies all patched-version specs across the full advisory set.@fastify/busboy
@fastify/busboywas installed transitively at2.1.1as a dependency ofundici@5.29.0. Onceundiciwas updated to6.27.0, the@fastify/busboydependency was dropped entirely —undici@6.xno longer depends on it — so the vulnerable2.1.1copy is removed from the lockfile as a natural consequence of theundiciupgrade with no additional manifest change needed.Version changes
@actions/core^1.10.0→1.11.1^2.0.0→2.0.3@actions/http-client@^3.xand transitivelyundici@^6.x@actions/github^6.0.0→6.0.0^8.0.0→8.0.1@actions/http-client@^3.xand transitivelyundici@^6.x@actions/http-client2.2.33.0.2@actions/core,@actions/github);3.xdeclaresundici@^6.23.0undici5.29.06.27.0@actions/http-client@3.0.2@fastify/busboy2.1.1undici@6.xno longer depends on this package