Fixed circuit.params inconsistency in circuit.updateParams()#31
Open
gijswl wants to merge 1 commit intoLenty:masterfrom
Open
Fixed circuit.params inconsistency in circuit.updateParams()#31gijswl wants to merge 1 commit intoLenty:masterfrom
gijswl wants to merge 1 commit intoLenty:masterfrom
Conversation
…ification in loop over itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undefined parameters could be erroneously removed from the circuit.params list in circuit.updateParams().
This happened when entries were removed from circuit.params inside the loop over circuit.params. This resulted in not all parameters being processed. Consequently, they are lost when circuit.params is reassigned to the array of undefined parameters.