Skip to content

Support custom component (e.g. textarea) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinresol wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support custom component (e.g. textarea) #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bc33e1
Support ref to <input> element
kevinresol Jan 4, 2020
59a9c5a
Allow specifying component (e.g. textarea)
kevinresol Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/inputfield.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,15 @@ var InputField = function (_Component) {
var _this2 = this;

var _props = this.props,
component = _props.component,
onInputChange = _props.onInputChange,
restProps = _objectWithoutProperties(_props, ['onInputChange']);
inputRef = _props.inputRef,
restProps = _objectWithoutProperties(_props, ['component', 'onInputChange', 'inputRef']);

return _react2.default.createElement('input', _extends({
type: 'text'
}, restProps, {
return _react2.default.createElement(component, _extends({}, restProps, {
ref: function ref(input) {
_this2.input = input;
if (inputRef) inputRef(input);
},
value: this.state.value,
onChange: this.handleInputChange,
Expand All @@ -122,6 +123,7 @@ InputField.propTypes = {
onInputChange: _propTypes2.default.func
};
InputField.defaultProps = {
component: 'input',
onChange: noop,
onInputChange: noop
};
Expand Down
25 changes: 13 additions & 12 deletions src/inputfield.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class InputField extends Component {
}

static defaultProps = {
component: 'input',
onChange: noop,
onInputChange: noop
}
Expand Down Expand Up @@ -71,18 +72,18 @@ class InputField extends Component {
}

render() {
const { onInputChange, ...restProps } = this.props
return (
<input
type='text'
{...restProps}
ref={(input)=>{this.input = input}}
value={this.state.value}
onChange={this.handleInputChange}
onCompositionStart={this.handleComposition}
onCompositionEnd={this.handleComposition}
/>
)
const { component, onInputChange, inputRef, ...restProps } = this.props
return React.createElement(component, {
...restProps,
ref: input => {
this.input = input;
if(inputRef) inputRef(input);
},
value: this.state.value,
onChange: this.handleInputChange,
onCompositionStart: this.handleComposition,
onCompositionEnd: this.handleComposition,
});
}
}

Expand Down