Skip to content

Conversation

@czirker
Copy link
Contributor

@czirker czirker commented Jan 23, 2026

Summary

  • Enable --all flag for nyc coverage to include all source files
  • Add new unit tests for better code coverage
  • Coverage improved from 23.16% to 25.75% lines (310 tests)

Changes

  • Updated .nycrc.json with all: true and proper include patterns
  • Added lib.aws-util.utest.ts - tests for aws-util module (20 tests)
  • Added lib.DynamodbFetcher.utest.ts - tests for DynamoDB fetcher
  • Added lib.parser-util.utest.ts - tests for parser utilities

Test plan

  • All existing tests pass
  • New tests pass
  • Coverage report generates correctly with --all flag

Note

Improves coverage and validation of core utilities without changing runtime code.

  • Updates .nycrc.json to include lib/**/*, wrappers/**/*.js, index.js and sets all: true for comprehensive coverage
  • Adds test/lib.aws-util.utest.ts covering copy, error, and date.getDate
  • Adds test/lib.DynamodbFetcher.utest.ts covering constructor behavior, keyToString, and join batching/deduplication paths
  • Adds test/lib.parser-util.utest.ts covering enums, fieldParsers, parsers, createParser, and FastJsonPlus

Written by Cursor Bugbot for commit 10f3094. This will update automatically on new commits. Configure here.

- Update .nycrc.json with all: true for comprehensive coverage

- Add lib.aws-util.utest.ts (20 tests)

- Add lib.DynamodbFetcher.utest.ts (DynamoDB fetcher tests)

- Add lib.parser-util.utest.ts (parser utility tests)

Coverage: 23.16% -> 25.75% (310 tests)
@ch-snyk-sa
Copy link

ch-snyk-sa commented Jan 23, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

"lib/**/*.js",
"wrappers/**/*.js",
"index.js"
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing TypeScript test file exclusion pattern

Low Severity

The exclude pattern only includes **/*.utest.js but not **/*.utest.ts. With all: true enabled and TypeScript extensions configured, nyc now processes .ts source files directly. If a .utest.ts file were created in the lib/ directory (matching the include pattern lib/**/*.ts), it wouldn't be excluded since **/*.utest.js only matches JavaScript test files. This could incorrectly inflate coverage metrics.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants