Fix blank page on refresh in Major and Cyclic physical inventory draft#80
Open
pitsophinnias wants to merge 1 commit into
Open
Fix blank page on refresh in Major and Cyclic physical inventory draft#80pitsophinnias wants to merge 1 commit into
pitsophinnias wants to merge 1 commit into
Conversation
- Major refresh: recover draft from cache using id from URL when program
and facility are missing from stateParams. Avoids crashing call to
getPhysicalInventory which requires programId and facilityId to load
stock card summaries. Program and facility resolves recover downstream
from draft.programId and getUserHomeFacility() as designed.
- Cyclic refresh: retain empty draft stub with clarifying comment. Cyclic
has no id in the URL and no server persistence, so the cache key
(cyclic-{programId}-{facilityId}) cannot be reconstructed on refresh.
Page renders in blank start state rather than throwing an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major refresh: recover draft from cache using id from URL when program and facility are missing from stateParams. Avoids crashing call to getPhysicalInventory which requires programId and facilityId to load stock card summaries. Program and facility resolves recover downstream from draft.programId and getUserHomeFacility() as designed.
Cyclic refresh: retain empty draft stub with clarifying comment. Cyclic has no id in the URL and no server persistence, so the cache key (cyclic-{programId}-{facilityId}) cannot be reconstructed on refresh. Page renders in blank start state rather than throwing an error.