Conversation
Add Android headphone rest alerts and an opt-in three-second DTMF countdown that obeys the notification setting. Preserve rest deadlines and stop playback on cancellation or audio route/focus changes.
|
Thanks for opening a PR! A few things that help this get reviewed:
PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Android rest notification with playback through active headphones and a generated tone sequence. The tones were the easiest thing I could do to try and be universal but i don't know if this really goes with the vibe of the app. If you don't want to take this there is a simpler version in which you just use the normal notification sound when the timer ends. Also please review the tones i used. There were just a quick solution but some other dial tone frequency might sound nicer to you. These are a little grating, but they get your attention!
- doing them independently caused some weird timing issues
The feature is Android-only and tested for 1 workout session.
This PR does not add iOS countdown audio nor is it tested.