Skip to content

Fix notification while on silent - #972

Open
Felixre7 wants to merge 4 commits into
LiamMorrow:mainfrom
Felixre7:review/fix-notification-while-on-silent
Open

Felixre7 wants to merge 4 commits into
LiamMorrow:mainfrom
Felixre7:review/fix-notification-while-on-silent

Conversation

@Felixre7

@Felixre7 Felixre7 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Fix Android rest notification with playback through active headphones and a generated tone sequence. The tones were the easiest thing I could do to try and be universal but i don't know if this really goes with the vibe of the app. If you don't want to take this there is a simpler version in which you just use the normal notification sound when the timer ends. Also please review the tones i used. There were just a quick solution but some other dial tone frequency might sound nicer to you. These are a little grating, but they get your attention!

  • Opt in for the 3 second count down and obey the main notification slider
  • Generate a single PCM buffer for the DTMF 4-4-4-6 sequence: 500 ms countdown tones and a one-second final tone.
    - doing them independently caused some weird timing issues
  • Preserve notification deadlines and clean up playback on completion, cancellation, and audio route/focus changes.

The feature is Android-only and tested for 1 workout session.
This PR does not add iOS countdown audio nor is it tested.

Add Android headphone rest alerts and an opt-in three-second DTMF countdown that obeys the notification setting. Preserve rest deadlines and stop playback on cancellation or audio route/focus changes.
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Thanks for opening a PR!

A few things that help this get reviewed:

  • Describe your changes clearly in the PR description, in your own words. AI-generated summaries tend to be more verbose than necessary and frustrating to read.
  • Read the AI Usage Policy.
  • Attach screenshots of any visual changes.
  • Make sure this PR follows an issue/feature request that's already been accepted as wanted (see Contributing).

PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant