Conversation
|
Thanks for opening a PR! A few things that help this get reviewed:
PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe. |
The plan subtree had no layout, so the plan view and the workout day editor were flattened into the settings stack as siblings. Editing a day from the home screen deep-linked straight to the editor, leaving the settings page as the only entry beneath it, so Back landed on Settings. Give manage-workouts/[programId] its own stack anchored on the plan view, so the day editor is always pushed on top of it and Back returns to the plan. The nested stack's <Stack.Screen> must be declared after index: declared screens are placed first in the stack's route order, so otherwise the settings tab would open straight into manage-workouts/[programId] with no programId and crash.
Felixre7
force-pushed
the
fix/plan-editor-back-navigation
branch
from
September 17, 2026 02:06
da7c92d to
454f934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes this issue: #870
I see you closed it but it is pretty annoying :')