Skip to content

Preserve the rest timer when correcting logged reps - #981

Open
Felixre7 wants to merge 1 commit into
LiamMorrow:mainfrom
Felixre7:fix/preserve-rest-timer-on-set-edits
Open

Felixre7 wants to merge 1 commit into
LiamMorrow:mainfrom
Felixre7:fix/preserve-rest-timer-on-set-edits

Conversation

@Felixre7

@Felixre7 Felixre7 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

fixes: #979

Fix

  • RecordedWeightedExercise.withRepCount keeps the set's original completion time.
  • Editing reps no longer resets a paused or dismissed rest timer; it only resets the timer when a set is actually (un)logged.
  • A failure state captured when the timer starts (failedAtStart) is carried through pause/resume so the rest window and notifications stay consistent with the logged set.

Editing the reps of an already-logged set kept the original completion time but restarted the rest timer from the edit, losing the elapsed/remaining rest. Correcting reps now keeps the set's completion time and leaves the running rest timer untouched.

A failure state captured when the timer starts (failedAtStart) is carried through pause/resume so the rest window and notifications stay consistent with the set that was actually logged.
@github-actions

Copy link
Copy Markdown

Thanks for opening a PR!

A few things that help this get reviewed:

  • Describe your changes clearly in the PR description, in your own words. AI-generated summaries tend to be more verbose than necessary and frustrating to read.
  • Read the AI Usage Policy.
  • Attach screenshots of any visual changes.
  • Make sure this PR follows an issue/feature request that's already been accepted as wanted (see Contributing).

PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe.

@Felixre7
Felixre7 marked this pull request as ready for review September 16, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Rest timer resets on set edit

1 participant