Conversation
Editing the reps of an already-logged set kept the original completion time but restarted the rest timer from the edit, losing the elapsed/remaining rest. Correcting reps now keeps the set's completion time and leaves the running rest timer untouched. A failure state captured when the timer starts (failedAtStart) is carried through pause/resume so the rest window and notifications stay consistent with the set that was actually logged.
|
Thanks for opening a PR! A few things that help this get reviewed:
PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe. |
Felixre7
marked this pull request as ready for review
September 16, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #979
Fix
RecordedWeightedExercise.withRepCountkeeps the set's original completion time.failedAtStart) is carried through pause/resume so the rest window and notifications stay consistent with the logged set.