Handle empty backup test requests - #983
Open
cannontrodder wants to merge 2 commits into
Open
cannontrodder wants to merge 2 commits into
cannontrodder wants to merge 2 commits into
Conversation
The deployed June Lambda rejects the app's empty test request; upstream added probe support in August. Handle every HTTP header casing so probes consistently succeed without creating an empty backup. Exercise storage with a complete gzipped SQLite fixture and its independently recorded database digest, and document upgrading older deployments.
|
Thanks for opening a PR! A few things that help this get reviewed:
PRs that clearly don't follow these likely won't get reviewed in a reasonable timeframe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWS reference implementation now handles the empty test request correctly when the probe header uses different casing.
Verified with upload/probe tests, API tests, build and formatting checks.
@LiamMorrow I see how you split the backends up so they can support particular features. What I might do is take a look at an AWS-hosted backend as well and see if there's a really cheap way to do it. If you've got that Docker container there, it shouldn't be too difficult, but those are famous last words.
This is all AI but I do always review it and I always write my own PRs for you.