Skip to content

Asktell/aposmm reg test with vocs + other changes#1679

Open
jlnav wants to merge 9 commits intoexamples/optimas_ax_generatorsfrom
asktell/aposmm_reg_test_vocs
Open

Asktell/aposmm reg test with vocs + other changes#1679
jlnav wants to merge 9 commits intoexamples/optimas_ax_generatorsfrom
asktell/aposmm_reg_test_vocs

Conversation

@jlnav
Copy link
Member

@jlnav jlnav commented Feb 18, 2026

Note several things:

  • We're still doing numpy back and forth for aposmm
  • But aposmm's x and f need to be "mapped" to core,edge,energy for vocs, since vocs also decides history
  • So mapping is needed, but not np_to_list_dicts mapping.
  • unmap_numpy_array is useful. the reverse was added, map_numpy_array.
  • the mapping of "sim_id" is special. if _id comes in, we swap it with sim_id. If sim_id goes out, we obviously want sim_id to come back
  • Simplification of list_dicts_to_np was more possible once we treated only the mapping fields as base truth if its in sync with the input data

…eGenInterfacer's, plus refactoring the aposmm calling script into how I'd like it to look eventually.
…y array into the H constructed from VOCS, then do the reverse for the numpy array from H back into APOSMM. Also ensure that _id data becomes sim_id, and vice-versa
- Hint towards easy bug where user may have intended to set sim_specs.simulator instead of sim_specs.sim_f

the regression test:
- use vocs for second test iteration

misc.py
- more reliably build the dtype out of mapping keys that are present in the input data

runners.py
- some cleanup
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.23%. Comparing base (a9b76ef) to head (4f8c912).

Files with missing lines Patch % Lines
libensemble/utils/misc.py 86.11% 2 Missing and 3 partials ⚠️
libensemble/gen_classes/aposmm.py 75.00% 1 Missing and 1 partial ⚠️
libensemble/history.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           examples/optimas_ax_generators    #1679      +/-   ##
==================================================================
- Coverage                           93.27%   93.23%   -0.04%     
==================================================================
  Files                                  81       81              
  Lines                                8207     8249      +42     
  Branches                             1253     1266      +13     
==================================================================
+ Hits                                 7655     7691      +36     
- Misses                                356      360       +4     
- Partials                              196      198       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlnav jlnav requested a review from shuds13 February 19, 2026 16:13
jlnav and others added 3 commits February 20, 2026 10:25
…rong simulator/sim_f parameter is set in sim_specs, and accordingly the wrong data is returned. test for this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments