Asktell/aposmm reg test with vocs + other changes#1679
Open
jlnav wants to merge 9 commits intoexamples/optimas_ax_generatorsfrom
Open
Asktell/aposmm reg test with vocs + other changes#1679jlnav wants to merge 9 commits intoexamples/optimas_ax_generatorsfrom
jlnav wants to merge 9 commits intoexamples/optimas_ax_generatorsfrom
Conversation
…eGenInterfacer's, plus refactoring the aposmm calling script into how I'd like it to look eventually.
…rators' into asktell/aposmm_reg_test_vocs
…y array into the H constructed from VOCS, then do the reverse for the numpy array from H back into APOSMM. Also ensure that _id data becomes sim_id, and vice-versa
- Hint towards easy bug where user may have intended to set sim_specs.simulator instead of sim_specs.sim_f the regression test: - use vocs for second test iteration misc.py - more reliably build the dtype out of mapping keys that are present in the input data runners.py - some cleanup
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## examples/optimas_ax_generators #1679 +/- ##
==================================================================
- Coverage 93.27% 93.23% -0.04%
==================================================================
Files 81 81
Lines 8207 8249 +42
Branches 1253 1266 +13
==================================================================
+ Hits 7655 7691 +36
- Misses 356 360 +4
- Partials 196 198 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Examples/optimas ax generators
…smm_reg_test_vocs
…rong simulator/sim_f parameter is set in sim_specs, and accordingly the wrong data is returned. test for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note several things: