feat(security): add server-side email HTML sanitizer utility#1108
Draft
JohnVillalovos wants to merge 1 commit intodevelopfrom
Draft
feat(security): add server-side email HTML sanitizer utility#1108JohnVillalovos wants to merge 1 commit intodevelopfrom
JohnVillalovos wants to merge 1 commit intodevelopfrom
Conversation
Add Symfony HTML sanitization support and introduce a reusable EmailHtmlSanitizer utility for email-safe rich text rendering. - add dependency: symfony/html-sanitizer (^7.4) - add EmailHtmlSanitizer class under lib/Common/Security - decode legacy HTML entities before sanitizing - allow basic formatting tags and safe link schemes If needed in the future could use the symfony/html-sanitizer for other tasks.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a server-side HTML sanitization utility intended for rendering “email-safe” rich text using Symfony’s html-sanitizer, with PHPUnit coverage.
Changes:
- Added
symfony/html-sanitizer(and transitive deps) to Composer requirements/lockfile. - Introduced
EmailHtmlSanitizerutility with an allowlist of basic formatting elements and safe link schemes. - Added unit tests covering allowed formatting, dangerous content removal, and legacy entity-decoding behavior.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/Common/Security/EmailHtmlSanitizer.php |
New sanitizer utility built on Symfony HtmlSanitizer with an allowlist config and legacy entity decode step. |
tests/Common/Security/EmailHtmlSanitizerTest.php |
New tests validating allowed tags, stripping dangerous content, and decoding encoded HTML before sanitization. |
composer.json |
Adds symfony/html-sanitizer to runtime dependencies. |
composer.lock |
Locks Symfony HtmlSanitizer and new transitive dependencies. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Symfony HTML sanitization support and introduce a reusable EmailHtmlSanitizer utility for email-safe rich text rendering.
If needed in the future could use the symfony/html-sanitizer for other tasks.