fix: guard model.to() calls against backend proxies in inference and validation#305
Open
imagra93 wants to merge 2 commits into
Open
fix: guard model.to() calls against backend proxies in inference and validation#305imagra93 wants to merge 2 commits into
imagra93 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 621cf18c0b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
|
This changes behaviour of the shared validator and thus affects every single model, which worries me. I think that such big change could come after the v1.2.0 release. This is the pushback that codex wrote while I was reviewing the PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InferenceRunner._set_device() in models/base/inference.py and GazeInferenceRunner._set_device() in models/l2cs/inference.py both call self.model.model.to(device) unconditionally. When the inner model is a _BackendEvalProxy (ONNX / TensorRT backend), the proxy has no .to() method — device management is the runtime's responsibility — so the call raises AttributeError and prediction fails.
Fix: wrap both .to() calls with a hasattr guard. model.device is still updated so the wrapper reflects the intended device; only the PyTorch-specific .to() transfer is skipped for proxies.