Fix roster synchronization and empty-row handling - #2
Open
ciolansteen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.playerbots bot listafter logging in bots and import its system-message roster into the local trackerPBM_ClassTabs.luaProblem
The addon stores its roster locally and
.playerbots bot add *does not populate that SavedVariables roster. Existing bots can therefore be online while the manager remains empty. In addition, unnamed rows containing stale class/spec data cannot be deleted because the delete handler returns early whenname == "".The login/logout buttons also used
PARTY, which the client rejects when the player is not grouped.Testing
C_Timercallbacks and the WotLKOnUpdatefallback both implement last-schedule-wins behaviorluac5.1 -ppassed for all 53 Lua filesgit diff --checkRoster synchronization has not yet been manually validated end-to-end in the WoW client against every server configuration.